Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vendored k8s to 1.11.3 #328

Merged
merged 1 commit into from
Jan 30, 2019
Merged

update vendored k8s to 1.11.3 #328

merged 1 commit into from
Jan 30, 2019

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #328   +/-   ##
======================================
  Coverage    50.5%   50.5%           
======================================
  Files          68      68           
  Lines        3188    3188           
======================================
  Hits         1610    1610           
  Misses       1317    1317           
  Partials      261     261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f5387...174a176. Read the comment docs.

@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Dec 18, 2018 •
edited
Loading

Updating vendored k8s here to 0.11.3 allows knative/build-pipeline to use the k8schain library, resolving this issue:

have Admissionregistration() "github.com/knative/build/vendor/k8s.io/client-go/kubernetes/typed/admissionregistration/v1beta1".AdmissionregistrationV1beta1Interface
want Admissionregistration() "github.com/google/go-containerregistry/vendor/k8s.io/client-go/kubernetes/typed/admissionregistration/v1beta1".AdmissionregistrationV1beta1Interface

which is due to:

Solving failure: No versions of github.com/google/go-containerregistry met constraints:
        master: Could not introduce github.com/google/go-containerregistry@master, as it has
 a dependency on k8s.io/client-go with constraint kubernetes-1.11.0, which has no overlap wi
th existing constraint kubernetes-1.11.3 from (root)
        master: Could not introduce github.com/google/go-containerregistry@master, as it has
 a dependency on k8s.io/client-go with constraint kubernetes-1.11.0, which has no overlap wi
th existing constraint kubernetes-1.11.3 from (root)
        add-the-tip: Could not introduce github.com/google/go-containerregistry@add-the-tip,
 as its subpackage github.com/google/go-containerregistry/pkg/authn/k8schain is missing. (Pa
ckage is required by (root).)

@jonjohnsonjr
Copy link
Collaborator

Is this because build-pipeline is using 1.11.3? Are we going to require all of our consumers to be on the same version? I wonder if the genericclioptions library is too difficult to have as a dependency 😢

@jonjohnsonjr jonjohnsonjr mentioned this pull request Dec 18, 2018
Closed
@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Dec 18, 2018 •
edited
Loading

it seems knative/pkg vendors also vendors 0.11.3 so it might be worth trying to update as there might be more issues in trying to use the kubeclient as a param in the libs together. When I updated knative/build-pipeline to to use my fork of go-containerregistry which has this updated there are new errors related the the Azure packages k8schain vendors.

Edit: My current plan is to have build-pipeline (at least as I'm trying to get things tested/working) use a kubeclient from the vendored kube lib.
Edit 2: Oops, seems you can't do that

@jonjohnsonjr
Copy link
Collaborator

cc @mattmoor

@aaron-prindle
Copy link
Contributor Author

@jonjohnsonjr yes, currently build-pipeline uses 0.11.3

@jonjohnsonjr
Copy link
Collaborator

Can you paste the errors you get when you try to use your fork?

@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Dec 18, 2018 •
edited
Loading

Errors using my fork w/ the updated k8s version:

2018/12/18 15:45:40 Unexpected error running "go build": exit status 2
# github.com/knative/build/vendor/github.com/Azure/azure-sdk-for-go/services/containerregist
ry/mgmt/2017-10-01/containerregistry
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:719:38: future.GetResult undefined (type *RegistriesCreateFuture has no
field or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:792:38: future.GetResult undefined (type *RegistriesUpdateFuture has no
field or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:821:39: future.GetResult undefined (type *RegistriesUpdatePoliciesFuture
 has no field or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:1488:38: future.GetResult undefined (type *ReplicationsCreateFuture has
no field or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:1538:38: future.GetResult undefined (type *ReplicationsUpdateFuture has
no field or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:2051:38: future.GetResult undefined (type *WebhooksCreateFuture has no f
ield or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/models.go:2101:38: future.GetResult undefined (type *WebhooksUpdateFuture has no f
ield or method GetResult)
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/registries.go:192:23: undefined: azure.NewFutureFromResponse
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/registries.go:271:23: undefined: azure.NewFutureFromResponse
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/registries.go:433:23: undefined: azure.NewFutureFromResponse
vendor/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containe
rregistry/registries.go:433:23: too many errors

I have tried tweaking the versions of azure-sdk-for-go but have so far always ended up with some set of errors.

@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Dec 19, 2018 •
edited
Loading

I was able to resolve the issues I was having with my fork. I pinned a different version of azure and changed the import paths of my fork to "aaron-prindle/go-containerregistry".

@jonjohnsonjr
Copy link
Collaborator

Can you pin that version in this PR?

@aaron-prindle
Copy link
Contributor Author

I actually pinned the version in go-containerregistry to be used in knative/build-pipeline and that resolved it. The versions here should work w/o change.

@aaron-prindle aaron-prindle mentioned this pull request Jan 2, 2019
Closed
@imjasonh imjasonh merged commit 4d5c197 into google:master Jan 30, 2019
@aaron-prindle
Copy link
Contributor Author

image

@imjasonh imjasonh mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaron-prindle @codecov-io @jonjohnsonjr @imjasonh